This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] test for ONEAPI_DEVICE_SELECTOR case sensitivity fix #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // RUN: env ONEAPI_DEVICE_SELECTOR="OPENCL:*" %t.out | ||
| // RUN: env ONEAPI_DEVICE_SELECTOR="opencl:*" %t.out | ||
| // RUN: env ONEAPI_DEVICE_SELECTOR="*:GPU" %t.out | ||
| // RUN: env ONEAPI_DEVICE_SELECTOR="*:gpu" %t.out |
There was a problem hiding this comment.
Would it make sense to have a test where it mixes upper and lowercase letters? I.e. something like OPeNcL or even an actual common spelling like OpenCL.
There was a problem hiding this comment.
Maybe. What if I removed all these cases for just one: "OpEnCl:GpU" ?
Co-authored-by: Steffen Larsen <[email protected]>
|
/verify with intel/llvm#8238 |
|
The "regular" test failures are expected. The Jenkins/llvm-test-suite run is the run against the PR with the new feature, and all tests are passing. |
againull
approved these changes
Feb 10, 2023
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Co-authored-by: Steffen Larsen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…vm-test-suite#1579) Co-authored-by: Steffen Larsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for ONEAPI_DEVICE_SELECTOR case sensitivity is here: intel/llvm#8238